This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Parse column names in a dataframe to avoid breaking the line protocol #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test for whatever you are trying to fix |
|
Is there a possibility to test against a previous release i.e one without the fix, just to see if the test case would catch the error |
|
Yes, you can test against a previous release by undoing your code and running the test. |
|
Something seems to be going wrong on the server side :
|
|
Build still fails due to what seems like flake8 environment issues on the server side. |
|
Any ideas how to resolve the flake8 errors? |
|
@dmuiruri i'll take a look at the failing flake8 run. |
xginn8
approved these changes
May 8, 2018
|
Thanks for contributing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dataframe contains spaces in the column names i.e tags and field keys, the spaces cause an error when the line protocol is applied, the spaces are however well handled when the protocol applied is json.
This is a fix to issue #583 .