RFC: Make sure extends() dies if we fail to load the parent package #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We update %INC in Mo::import() for caller pkg, to cope with inline classes. Signed-off-by: Pedro Melo <[email protected]>
|
I just got bitten by this particular piece of behaviour. I don't know what the issue with the tests files is, but I find the lack of an exception on failure to load a parent class to be confusing, and a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the package in extends() fails to load (either because of a typo or a syntax error), Mo silently ignores this and keeps going. This changes make extends() propagate the error message that
no PACKAGE ()generates.OTOH this makes inline classes (like those used on
t/build.tandt/test.t) stop working because inline classes don't update %INC and so a follow up extends() in a child class would die with "Cannot find PACKAGE.pm".We changed Mo::import() to update %INC if needed. This may have other consequences that I'm not thinking about right now. If so, please suggest an alternative to support inline classes, I will update my branch with it.
Signed-off-by: Pedro Melo [email protected]