Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Support post job phase #1

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

paulolieuthier
Copy link

Support using github-script with post phase and shared prelude.

Copy link

@t0rr3sp3dr0 t0rr3sp3dr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either we should make this patch to upstream, or change it so instead of having support for post GitHub Script, we have support for post Bash Script. We are using this on inloco/actions-cache and there we are basically calling Bash from Node, it would be more useful to have pre-run, run, and post-run that receive bash scripts and execute them.

@paulolieuthier
Copy link
Author

I think either we should make this patch to upstream

I don't think that would be accepted in upstream, which has a very simple API. prelude, for instance, might look too weird for them, even though I believe it's important to avoid code duplication and improve maintainability.

change it so instead of having support for post GitHub Script, we have support for post Bash Script.

That's actually how I started. But there are some special auxiliary functions provided by github-script that are very helpful, like the file globber, to describe files in a standard way for GitHub Actions workflows.

dependabot bot and others added 7 commits March 26, 2022 06:03
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Update README with Markdown text formatting example
…inimist-1.2.6

Bump minimist from 1.2.5 to 1.2.6
Pull requests from forks do not have write permission, so we need to use `pull_request_target` instead of `pull_request` to enable write permission.

Fixes actions#42.
README: use pull_request_target in example
@paulolieuthier paulolieuthier force-pushed the feature/initial-implementation branch from 7da83f5 to d61bd36 Compare April 13, 2022 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants