Issue/10351 stale session bugfix iso9#10448
Closed
Hugo-Inmanta wants to merge 3 commits into
Closed
Conversation
…y towards the database could sometimes cause the scheduler to miss new versions notifications. (Issue #10351, PR #10415) Iso8 + 9 only since the websocket refactor on iso10 removed most of the session management logic. closes #10351 Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
arnaudsjs
approved these changes
Jun 8, 2026
Contributor
|
Processing this pull request |
Contributor
|
Merged into branches iso9 in 9b63cfe |
inmantaci
pushed a commit
that referenced
this pull request
Jun 8, 2026
…y towards the database could sometimes cause the scheduler to miss new versions notifications. (Issue #10351, PR #10448) # Description iso9 PR for #10415 Only diff is in the `test_session_expiration` test: the methods to break and re-enable connectivity with the db are `data.connect_pool` and `data.disconnect_pool` (vs iso8 `data.connect` and `data.disconnect`) # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
iso9 PR for #10415
Only diff is in the
test_session_expirationtest: the methods to break and re-enable connectivity with the db aredata.connect_poolanddata.disconnect_pool(vs iso8data.connectanddata.disconnect)Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box