Restoring terminal settings after daemonizing. #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Rodriguez <[email protected]>
304b798 to
c32e7c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves the problem with misconfigured terminal after starting a daemon. This has been reported as Issue #200 "Executing barrierc makes terminal line invisible #200".
The problem is that the parent process just calls exit(0) after starting the child process. The terminal settings have to be restored before exit.
Going back through issues - I'm rebasing this against master, if it passes CI, we could merge.
OK, I can't push against your branch, as its master, so I need you to rebase against master - or I could open a new PR for this. Alternatively, if you could allow access to your PR's branch, I could do it then.
EDIT: I managed to rebase against your branch. Now we wait for CI to pass.
Looks like Windows builds fail -
restoreTerminalisn't a member of theNonBlockingStream. I'll look into this. Interestingly, Linux builds are succeeding - so I suspect this is a Windows-only issue.