feat: Refactor OSX event buffer from Carbon to Grand Central Dispatch #2164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request introduces a refactored version of the OSXEventQueueBuffer class, transitioning from the original Carbon-based implementation to a modern Grand Central Dispatch (GCD)-based approach. The key modifications include:
The purpose of this fix is to address a repeated crashing behavior I saw in mac OS 15.2 where I'd see logs like:
I read that
PostEventToQueue
calls are strongly discouraged in modern macOS and that might explain this bad pointer reference I'm seeing.Contributor Checklist:
doc/newsfragments
directory (and made sure to read theREADME.md
in that directory)