Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

useDataset and useThing hooks #119

Merged
merged 12 commits into from
Sep 15, 2020
Merged

useDataset and useThing hooks #119

merged 12 commits into from
Sep 15, 2020

Conversation

andydavison
Copy link
Contributor

New feature description

  • Adds useDataset and useThing hooks, using useSWR internally and pulling in session from context
  • Refactors dataset context to use useDataset

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@andydavison andydavison changed the title Feature/usedataset usething hooks useDataset and useThing hooks Sep 14, 2020
ajacksified
ajacksified reviewed Sep 14, 2020
View reviewed changes
@andydavison andydavison force-pushed the feature/usedataset-usething-hooks branch from efe6652 to e1fdd5a Compare September 14, 2020 12:46
ajacksified
ajacksified reviewed Sep 14, 2020
View reviewed changes
@andydavison andydavison force-pushed the feature/usedataset-usething-hooks branch from 2fd000f to 0be7ccf Compare September 14, 2020 13:03
@andydavison andydavison force-pushed the feature/usedataset-usething-hooks branch from 0be7ccf to ced7aae Compare September 14, 2020 13:08
@andydavison andydavison force-pushed the feature/usedataset-usething-hooks branch from ced7aae to a0d28a6 Compare September 14, 2020 13:23
ajacksified
ajacksified approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@ajacksified ajacksified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to figure out the best way to document these as stories - but this is good for now!

@andydavison andydavison merged commit 092e0cb into master Sep 15, 2020
@andydavison andydavison deleted the feature/usedataset-usething-hooks branch September 15, 2020 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ajacksified ajacksified ajacksified approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andydavison @ajacksified