This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Feat: add delete functionality to Image component #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add delete option to image component - add tests
NSeydoux
approved these changes
Jan 17, 2022
src/components/image/index.test.tsx
Outdated
| it("Should call saveSolidDatasetAt when clicking delete button", async () => { | ||
| jest | ||
| .spyOn(SolidFns, "saveSolidDatasetAt") | ||
| .mockResolvedValue(mockDataset as any); |
There was a problem hiding this comment.
Adding
import type {
SolidDataset,
WithChangeLog,
WithServerResourceInfo,
} from "@inrupt/solid-client";
in the imports and replacing this with mockDataset as SolidDataset & WithServerResourceInfo & WithChangeLog should remove the warning.
Comment on lines
+127
to
+129
| await saveSolidDatasetAt(datasetSourceUrl, updatedDataset, { | ||
| fetch, | ||
| }); |
There was a problem hiding this comment.
Shouldn't this only happen when autosave is set ? Or is it by design that when deleting an image you're automatically deleting it from the remote storage ?
There was a problem hiding this comment.
Good question. I am not sure but I have added a check for autosave since it is what we do with other operations as well.
src/components/image/index.tsx
Outdated
| const handleDelete = async () => { | ||
| if (!propThing || !solidDataset || !propProperty || !value) return; | ||
| try { | ||
| const updatedThing = removeUrl(propThing, propProperty, value as string); |
There was a problem hiding this comment.
If the preceding if was changed so that it tests typeof value === 'string' rather than !value, would the type assertions still be needed ?
78ab797 to
79cf869
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image component delete functionality
This PR adds an optional
allowDeleteprop to the Image component which renders a default delete button that will remove the image value from the dataset.It is also possible to pass a
deleteComponentto render a custom delete button.Checklist
index.ts, if applicable..tsfiles) are listed in theexportsfield inpackage.json, if applicable..tsfiles) are listed in thetypedocOptions.entryPointsfield intsconfig.json, if applicable.