feat: allow skipping loading the profile #695
Conversation
097e64b to
eec61b8
Compare
eec61b8 to
21f9262
Compare
| sessionInfo?.webId !== undefined | ||
| ? getProfileAll(sessionInfo?.webId, { | ||
| fetch: session.fetch, | ||
| }) | ||
| : undefined | ||
| ) |
There was a problem hiding this comment.
I assume the issue is that getProfileAll fails due to a network error if the WebID document isn't provisioned. If that's correct, could this be fixed by catching exceptions, and behaving as if the profile isn't available? If that was possible, it would be easier than having to manually skip this step.
There was a problem hiding this comment.
I think for now, manually skipping is the best approach, as I don't think we should be pre-fetching the profile/webid anymore, and instead provide a dedicated hook for it.
There was a problem hiding this comment.
As an aside, due to how this code is structured, the catch at the end can catch more than what it intends to, we should probably switch this from a promise chain to async/await
21f9262 to
a83ea1b
Compare
This is useful when using the React SDK to build a start/provisioning app, where the user will be able to login, but won't yet have a profile or WebID
a83ea1b to
6403ce0
Compare
Currently when using
<SessionProvider>it automatically tries to load the WebID & associated Profile Documents, in most applications, this is okay, but when building a start/provisioning application, this behaviour is not desirable as the user does not yet have a WebID or Profile.This change adds an experimental prop to
<SessionProvider>that allows disabling the automatic loading of profiles. This prop is considered experimental as the API has not yet stabilised and may change in a future major version.Usage
Checklist
index.ts, if applicable..tsfiles) are listed in theexportsfield inpackage.json, if applicable..tsfiles) are listed in thetypedocOptions.entryPointsfield intsconfig.json, if applicable.