mask: replace --threshold with --vmin/vmax #1009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
mask.py: replace the-t / --thresholdoption with the--vmin / --mask-vminoption, to be less ambiguous, as vmin includes the direction for thresholding.mask.py: add--vmax / --mask-vmaxoptionutils.isce_utils.unwrap_snaphu: support 2-band corr file, by checking the number of bands for the input correlation files, and set the file format accordingly, to support both the phase sigma and complex correlation files.utils.readfile.read_binary_file(): add file/dset size checkingview: bugfix for--mask-vmin/vmaxoptionsutils.plot.read_mask(): when--mask-vmin/vmaxoptions are specified, create mask via thresholding the 2D matrix of the mask file, instead of updating mask on top of the 2D matrix of the mask file.Reminders