Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@taliboliver
Copy link
Contributor

@taliboliver taliboliver commented Mar 5, 2024

Adding option to read center incidence angle from attribute file if available and use it as preferred option.

Proposing these changes after encountering a range_n value smaller that the acquisition height for UAVSAR dataset swatch_00540.

This error was also encountered by @alhandwerger

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

Adding option to read center incidence angle from metadata if available and use it as preferred option.
@yunjunz yunjunz self-requested a review March 5, 2024 15:04
@yunjunz yunjunz changed the title Read incidence angle from attribute file in utils0.py utils0.incidence_angle: read from metadata directly if available for dimension==0 Mar 5, 2024
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @taliboliver for the fix, LGTM.

@yunjunz yunjunz merged commit 0363d89 into insarlab:main Mar 5, 2024
@taliboliver taliboliver deleted the center_inc_angle branch March 5, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants