dem_error: bugfix on the step func
#1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the bug that the input step function date in cmd and template file was NOT corrected passed into the design matrix, due to the inconsistent usage of the variable naming. + rename stepFuncDate to stepDate in all `dem_error` related code and docs + prep_hyp3: add hdf-eos5 metadata extraction + docs/demo: use list to break lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fix the bug that the input step function date in cmd and template file was NOT corrected passed into the design matrix, due to the inconsistent usage of the variable naming, which was introduced in #823 and identified during the recent Ridgecrest example dataset testing (#1180).
rename stepFuncDate to stepDate in all
dem_errorrelated code and docsprep_hyp3: add hdf-eos5 metadata extraction
docs/demo: use list to break lines
Reminders