Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Jul 26, 2024

Description of proposed changes

  • utils.arg_utils.add_gnss_argument(): rename --gnss-source JPL-SIDESHOW to SIDESHOW for simplicity

  • objects.gnss: use SIDESHOW instead of JPL-SIDESHOW or JPL_SIDESHOW for all variable names and values

  • objects.gnss: add reference info in the code comments for GNSS_UNR/SIDESHOW, did not find citation/reference info for GNSS_ESESES, thus, did not add it yet.

  • docs.references.md: update to reflect the current references noted in the smallbaselineApp.cfg file.

Unrelated changes:

  • utils.network.simulate_coherence(): convert SNR from dB to 1 for thermal decorrelation

Reminders

  • Fix rename --gnss-source from JPL-SIDESHOW to SIDESHOW #1228
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ utils.arg_utils.add_gnss_argument(): rename --gnss-source JPL-SIDESHOW to SIDESHOW for simplicity

+ objects.gnss: use "SIDESHOW" instead of "JPL-SIDESHOW" or "JPL_SIDESHOW" for all variable names and values

+ objects.gnss: add reference info in the code comments for GNSS_UNR/SIDESHOW, did not find citation/reference info for GNSS_ESESES, thus, did not add it yet.

+ docs.references.md: update to reflect the current references noted in the smallbaselineApp.cfg file.

Unrelated changes:

+ utils.network.simulate_coherence(): convert SNR from dB to 1 for thermal decorrelation
@yunjunz yunjunz requested a review from rzinke July 26, 2024 07:54
@yunjunz yunjunz merged commit 75c5608 into insarlab:main Jul 29, 2024
@yunjunz yunjunz deleted the gnss-sideshow branch July 29, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rename --gnss-source from JPL-SIDESHOW to SIDESHOW

1 participant