Thanks to visit codestin.com
Credit goes to github.com

Skip to content

enable save_kmz for wrapped ifg by fixing plot.scale_data2disp_unit() #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yunjunz merged 2 commits into from
Sep 14, 2024
Merged

enable save_kmz for wrapped ifg by fixing plot.scale_data2disp_unit() #1269

yunjunz merged 2 commits into from
Sep 14, 2024

Conversation

@tshreve
Copy link
Contributor

@tshreve tshreve commented Sep 11, 2024 •
edited by yunjunz
Loading

Description of proposed changes

Added changes to plot.py to not calculate WAVELENGTH when displaying a wrapped interferograms in radians. Previously, an error was thrown when running save_kmz.py, since there is no wavelength defined in isce2 wrapped interferogram metadata.

Reminders

@welcome
Copy link

welcome bot commented Sep 11, 2024

💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖
Keep in mind that all new features should be documented. It helps to write the comments next to the code or below your functions describing all arguments, and return types before writing the code. This will help you think about your code design and usually results in better code.

@yunjunz yunjunz self-requested a review September 14, 2024 09:54
@yunjunz yunjunz changed the title Enable save_kmz for wrapped interferograms enable save_kmz for wrapped interferograms by fixing plot.scale_data2disp_unit() Sep 14, 2024
@yunjunz yunjunz changed the title enable save_kmz for wrapped interferograms by fixing plot.scale_data2disp_unit() enable save_kmz for wrapped ifg by fixing plot.scale_data2disp_unit() Sep 14, 2024
yunjunz
yunjunz approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @tshreve!

@yunjunz yunjunz merged commit 97404ae into insarlab:main Sep 14, 2024
@welcome
Copy link

welcome bot commented Sep 14, 2024

🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yunjunz yunjunz yunjunz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

save_kmz.py for wrapped ISCE2 interferogram

2 participants

@tshreve @yunjunz