Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gnss: change http to https for UNR URLs #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yunjunz merged 2 commits into from
Apr 1, 2025
Merged

gnss: change http to https for UNR URLs #1332

yunjunz merged 2 commits into from
Apr 1, 2025

Conversation

@rzinke
Copy link
Contributor

@rzinke rzinke commented Mar 20, 2025 •
edited by sourcery-ai bot
Loading

Update web address for UNR GPS data

University of Nevada Reno National Geodetic Laboratory has updated their web addresses to http secure protocol. This PR updates the appropriate links in the mintpy.objects.gnss module.

Tested with:

gnss_source = 'UNR'

from mintpy.objects import gnss

# Get analysis metadata from InSAR velocity file
(S,N,W,E) = (34.65836106, 35.60002848, -116.620093296, -114.38925817799999)
start_date = '20180105'
end_date = '20181231'

# Search for collocated GNSS stations
site_names, _, _ = gnss.search_gnss(SNWE=(S,N,W,E),
                                    start_date=start_date,
                                    end_date=end_date,
                                    source=gnss_source)
site_names = [str(site_name) for site_name in site_names]
n_sites = len(site_names)
print(f"{n_sites:d} found")

for site_name in site_names:
    print(f"Downloading {site_name:s}")
    gnss_stn = gnss.get_gnss_class(gnss_source)(site = site_name)
    gnss_stn.open(print_msg=False)

The download is currently slow on my home machine (8 minutes for 27 stations). I do not know if it is faster on different networks or at different times of day.

Summary by Sourcery

Updates UNR URLs from HTTP to HTTPS to use a secure protocol.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 20, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the URLs for the University of Nevada Reno (UNR) GNSS data source from HTTP to HTTPS. This change ensures that the application uses a secure connection when accessing data from UNR.

Updated class diagram for the UNR GNSS data source

classDiagram
    class UNR {
      -url_prefix: str
      -url: str
      +__init__(site: str, data_dir: str, version: str, url_prefix: str)
      +dload_site(overwrite: bool, total_tries: int, print_msg: bool)
    }
    note for UNR "URLs updated from HTTP to HTTPS"
Loading

File-Level Changes

Change Details Files
Updated the base URLs for the UNR data source from HTTP to HTTPS.
  • Updated the GNSS_SITE_LIST_URLS dictionary to use HTTPS for the UNR URL.
  • Updated the url_prefix attribute in the GNSS_UNR class to use HTTPS.
  • Updated the plot_file_url attribute in the dload_site method to use HTTPS.
 src/mintpy/objects/gnss.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rzinke - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing the print statement added for debugging before merging.
  • It would be good to add a comment explaining why the URL needs to be updated.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yunjunz yunjunz changed the title Changed http to https for UNR URLs gnss: change http to https for UNR URLs Apr 1, 2025
yunjunz
yunjunz approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @rzinke!

@yunjunz yunjunz merged commit 8dbf4b1 into insarlab:main Apr 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@yunjunz yunjunz yunjunz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rzinke @yunjunz