circleci: update miniforge setup
#1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ .circleci/config.yml: replace `mamba init bash` with `source conda/mamba.sh`, as suggested by its github repo readme at https://github.com/conda-forge/miniforge?tab=readme-ov-file#as-part-of-a-ci-pipeline
Contributor
Reviewer's GuideThis PR updates the CircleCI Miniforge setup to follow the official recommendations by dynamically downloading the correct OS/architecture installer and sourcing the Conda and Mamba shell scripts instead of using Sequence diagram for the updated Miniforge setup in CircleCIsequenceDiagram
participant CircleCI_Job as "CircleCI Job"
participant GitHub_Releases as "GitHub Releases"
participant Shell_Environment as "Shell Environment"
CircleCI_Job->>Shell_Environment: 1. Create/access tools directory
CircleCI_Job->>GitHub_Releases: 2. Download Miniforge (OS/Arch specific installer)
GitHub_Releases-->>CircleCI_Job: Miniforge Installer Script
CircleCI_Job->>Shell_Environment: 3. Install Miniforge from script
CircleCI_Job->>Shell_Environment: 4. Source conda.sh for initialization
CircleCI_Job->>Shell_Environment: 5. Source mamba.sh for initialization
CircleCI_Job->>Shell_Environment: 6. Update PATH in BASH_ENV for subsequent steps
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @yunjunz - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
.circleci/config.yml: replacemamba init bashwithsource conda/mamba.sh, as suggested by its GitHub repo readme at https://github.com/conda-forge/miniforge?tab=readme-ov-file#as-part-of-a-ci-pipeline, to fix the current circle CI environment setup error.Reminders
Summary by Sourcery
Improve the CircleCI miniforge setup by downloading the installer dynamically and sourcing the conda and mamba initialization scripts to resolve environment configuration errors.
Bug Fixes:
mamba init.Enhancements:
mamba init bashwithsource conda.shandsource mamba.shto configure the shell in CI.CI:
.circleci/config.ymlto install and configure Miniforge correctly in the pipeline.