Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Jun 11, 2025

Description of proposed changes

This PR adds support for loading the SNAPHU-generated connected components for Gamma interferogram stacks, thereby allowing unwrapping error corrections for Gamma products, as requested by @AoqingGuo-Ucb in #1375. Detailed changes are:

  • cli.prep_gamma.py: add .conncomp to the supported file extension

  • prep_gamma.py: add special treatment in the lks and DATA_TYPE extraction for the connected component file

  • utils.readfile.get_slice_list(): return only ["phase"] if there is only one band, such as the case of gamma .unw file.

Reminders

Summary by Sourcery

Enable support for SNAPHU-connected component (.conncomp) files in Gamma interferogram preprocessing, including CLI recognition, metadata handling, and phase-only data slicing.

New Features:

  • Recognize .conncomp files in the CLI and include them in the supported input extensions
  • Extend metadata extraction to handle .conncomp files by adjusting look parameter parsing and setting DATA_TYPE to BYTE

Enhancements:

  • Return only the phase band when reading single-band Gamma .unw files

Documentation:

  • Update CLI help text and examples to mention .conncomp and its corresponding .rsc file

yunjunz added 2 commits June 11, 2025 12:25
+ cli.prep_gamma.py: add `.conncomp` to the supported file extension

+ prep_gamma.py: add special treatment in the `lks` and `DATA_TYPE` extraction for connected component file

+ utils.readfile.get_slice_list(): return only [`phase`] if there is only one band, such as the case of gamma .unw file.
@yunjunz yunjunz merged commit a84abe7 into insarlab:main Jun 11, 2025
7 checks passed
@yunjunz yunjunz deleted the gamma_conncomp branch June 11, 2025 06:20
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yunjunz - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟒 General issues: all looks good
  • 🟒 Security: all looks good
  • 🟒 Testing: all looks good
  • 🟒 Complexity: all looks good
  • 🟒 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Unwrapping Error Correction] Unsupported .conncomp file format causes smallbaselineApp.py to fail

1 participant