Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Jul 6, 2025

Description of proposed changes

  • version: add version tag for v1.6.2

  • utils.isce_utils.unwrap_snaphu(): create RSC file if input has one as well

  • cli.geocode: more usage example for isce2 files

  • save_kmz: remove whitespace while showing the figure title

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

Summary by Sourcery

Prepare for v1.6.2 release by bumping version, preserving .rsc metadata in SNAPHU unwrapping, enhancing KMZ output formatting, and enriching geocode CLI examples.

Enhancements:

  • Make unwrap_snaphu generate ROI-PAC .rsc files when the input .rsc exists
  • Strip whitespace from autogenerated figure titles in save_kmz outputs

Build:

  • Update project version tag to v1.6.2 in release history

Documentation:

  • Add ISCE-2 .rdr usage examples to the geocode CLI help

+ version: add version tag for v1.6.2

+ utils.isce_utils.unwrap_snaphu(): create RSC file if input has one as well

+ cli.geocode: more usage example for isce2 files

+ save_kmz.py: remove whitespace while showing the figure title
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 6, 2025

Reviewer's Guide

Release prep for v1.6.2: bumped version tag, enhanced unwrap_snaphu to include RSC outputs when inputs exist, refined CLI geocode examples for ISCE-2 workflows, and stripped spaces from KMZ figure titles.

Class diagram for save_kmz whitespace removal in figure title

classDiagram
    class save_kmz {
        +save_kmz(inps)
        - inps.fig_title now has spaces removed via .replace(' ', '')
    }
    class pp {
        +auto_figure_title(file, dset, inps)
    }
    save_kmz ..> pp : uses
Loading

Class diagram for version tag update in version.py

classDiagram
    class version {
        +release_history : tuple of Tag
    }
    class Tag {
        +version : str
        +date : str
    }
    version o-- Tag
    version : + Added Tag('1.6.2', '2025-07-07')
Loading

File-Level Changes

Change Details Files
Bump project version to v1.6.2
  • Inserted new Tag('1.6.2','2025-07-07') in release history
src/mintpy/version.py
Generate RSC metadata in unwrap_snaphu when input RSC is present
  • Added conditional write of roipac .rsc after primary unwrap output
  • Added conditional write of roipac .rsc for connected components output
src/mintpy/utils/isce_utils.py
Refine geocode CLI examples for ISCE-2 workflows
  • Introduced a separate multilook step in examples
  • Simplified latitude/longitude file references in usage
src/mintpy/cli/geocode.py
Remove spaces from auto-generated KMZ figure titles
  • Applied replace(' ','') to the generated figure title string
src/mintpy/save_kmz.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yunjunz - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yunjunz yunjunz merged commit 86a07ed into insarlab:main Jul 7, 2025
7 checks passed
@yunjunz yunjunz deleted the version branch July 7, 2025 02:50
@yunjunz yunjunz restored the version branch July 7, 2025 03:20
@yunjunz yunjunz deleted the version branch July 7, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant