Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Oct 25, 2022

Description of proposed changes

  • smallbaselineApp: fix the bug of empty template file in _read_template(), which results in TypeError while running smallbaselineApp.py --plot (Fix smallbaselineApp.py --plot fails #878)

  • tests/smallbaselineApp: use abspath() to fix the bug while using --dir for a different direction for testing

  • modify_network: print given ifg index number, instead of ordering number, to be more informative

  • setup: uncomment pysolid as it's now available on pypi

Reminders

  • Pass Codacy code review (green)
  • Pass Pre-commit check (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.

+ smallbaselineApp: fix the bug of empty template file in _read_template(), which results in TypeError while running `smallbaselineApp.py --plot`

+ tests/smallbaselineApp: use abspath() to fix the bug while using --dir for a different direction for testing

+ modify_network: print given ifg index number, instead of ordering number, to be more informative

+ setup: uncomment pysolid as it's now available on pypi
@yunjunz yunjunz merged commit c15ad0f into insarlab:main Oct 26, 2022
@yunjunz yunjunz deleted the bugfix branch October 26, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

smallbaselineApp.py --plot fails

1 participant