closure_phase_bias: use wrapPhase if available
#922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 prefer use of wrapped phase, only use unwrapped phase when no wrapped phase is found 2 eliminates the need for a reference point for computation of wrapped closure phase
Changing multiply multiple complex phases to sum phases then make it complex -- seems to be a lot faster this way
bug fix
minor fix
yunjunz
reviewed
Nov 30, 2022
wrapPhase if available
Added explanation for removing the reference point
Contributor
Author
|
Now added an explanation for removing the reference point when creating the wrapped closure phase. |
Give some info regarding necessity of a reference point for action quick_estimate and estimate.
yunjunz
approved these changes
Dec 2, 2022
Member
yunjunz
left a comment
There was a problem hiding this comment.
LGTM, thank you @yjzhenglamarmota!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some issues with filtering implemented in ISCE2, I added the option of using wrapped phase (read from fine.int) to compute closure phase.
Now if there are wrapped phase in the ifgramStack.h5, wrapped phase will be used instead of the unwrapped phase.
conda activate mintpyandmamba install isce2