Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Mar 7, 2023

Description of proposed changes

  • utils.utils1.get_residual_std/rms():

  • timeseries_rms.read_template2inps(): pass no/False values from mintpy.residualRMS.maskFile/deramp/cutoff template options to variables, as they are valid inputs.

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

yunjunz added 2 commits March 7, 2023 21:10
+ utils.utils1.get_residual_std/rms():
   - always check the time info using the residual file for run_or_skip, instead of using the deramped residual file, as the former makes more sense.
   - treat the empty/false-value `ramp_type` same as `no` value, while determining the output file name from `mintpy.residualRMS.deramp` template option.

+ timeseries_rms.read_template2inps(): pass `no/False` values from `mintpy.residualRMS.maskFile/deramp/cutoff` template options to variables, as they are valid inputs.
@yunjunz yunjunz merged commit 91b5151 into insarlab:main Mar 7, 2023
@yunjunz yunjunz deleted the rms branch March 7, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timeseries_rms.py does not overwrite rms_timeseriesResidual_ramp.txt when it should

1 participant