Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Apr 28, 2023

Description of proposed changes

This PR add the timeseries2velocity.py --polyline option (and for tsview.py as well). Given one or multiple dates, this option will estimate an additional linear slope starting from the specified date, to catch the linear velocity change of a time-series. The result is saved in the velocity.h5 file as a dataset named velocityPost{YYYYMMDD}, which is the linear velocity during this segment time period, i.e. the sum of the velocity for the entire period (from the regular polynomial fitting), plus all the additional velocity change before & during the current segment periods.

Detailed changes are as below:

  • utils.time_func: construct a design matrix for polyline fitting with the manually specified starting date for each additional line segment

  • utils.arg_utils.add_timefunc_argument(): add --polyline option

  • timeseries2velocity:

    • model2hdf5_dataset(): support the polyline function and save the total/cumulative velocity for each polyline segment for easy visualization and interpretation.
    • check input --polynomial and --polyline options
  • cli.timeseries2velocity: add example usage

@yuankailiu I would appreciate it if you could take a look at these changes above when you got a chance?

Other changes not relevant to --polyline:

  • utils.ptime:

    • date_list2tbase(): add ref_date arg
    • date_list2vector(): add seconds arg
  • utils.arg_utils.add_figure_argument(): add --cbar-ticks option for accurate control on the colorbar tick positions.

  • simulation.iono.lalo_ground2iono(): more comments

  • tsview: printout msg minor adjustment

    • remove redundant print cmd. Now the tsview cmd msg will always be printed out.
    • always printout the save fig/txt file info, as it's very informative
  • objects.gps: change the default folder to store the site list file from ./ to ./GPS.

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ utils.time_func: construct design matrix for polyline fitting with manually specified starting date for each additional line segment

+ utils.arg_utils:
   - add_timefunc_argument(): add --polyline option
   - add_figure_argument(): add --cbar-ticks option for accurate control on the colorbar tick positions.

+ timeseries2velocity:
   - model2hdf5_dataset(): support polyline function and save the total/cumulative velocity for each polyline segments for easy visualization and interpretation.
   - check input --polynomial and --polyline options

+ cli.timeseries2velocity: add example usage

Other changes not relevant to --polyline:

+ utils.ptime:
   - date_list2tbase(): add `ref_date` arg
   - date_list2vector: add `seconds` arg

+ simulation.iono.lalo_ground2iono(): more comments

+ tsview: printout msg minor adjustment
   - remove redundant print cmd. Now the tsview cmd msg will always be printed out.
   - always printout the save fig/txt file info, as it's very informative

+ objects.gps: change the default folder to store the site list file from `./` to `./GPS`.
@yunjunz yunjunz requested a review from yuankailiu April 28, 2023 07:38
@yuankailiu
Copy link
Contributor

@yunjunz, thanks for the PR. Yes I will take a look.

Copy link
Contributor

@yuankailiu yuankailiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think it looks good to me.

@yunjunz yunjunz merged commit adad64f into insarlab:main May 5, 2023
@yunjunz yunjunz deleted the polyline branch May 5, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants