Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add sys prompt to config #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
reidliu41 wants to merge 1 commit into from
Closed

add sys prompt to config #2271

reidliu41 wants to merge 1 commit into from
+53 −1

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Sep 15, 2024 •
edited
Loading 

$ ilab model chat --help
Usage: ilab model chat [OPTIONS] [QUESTION]...

  Runs a chat using the modified model

Options:
  --system-prompt TEXT            Custom system prompt. If not provided, it
                                  will use the default context. [default:
                                  <None>; config: 'chat.system_prompt']

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if nessessary.
  • E2E Workflow tests have been added, if necessary.

Easy updates: can change the system prompt without touching the code.
Customization: Users can set their own prompt to fit different needs.
Consistency: Ensures the same prompt is used everywhere.
Flexibility: Prepares for future use of multiple prompts.
Better organization: Keeps settings separate from the code.

@mergify mergify bot added the ci-failure PR has at least one CI failure label Sep 16, 2024
leseb
leseb reviewed Sep 17, 2024
View reviewed changes
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Sep 17, 2024
cdoern
cdoern previously requested changes Sep 18, 2024
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @reidliu41 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added needs-rebase This Pull Request needs to be rebased ci-failure PR has at least one CI failure and removed needs-rebase This Pull Request needs to be rebased ci-failure PR has at least one CI failure labels Sep 19, 2024
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @reidliu41 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added needs-rebase This Pull Request needs to be rebased ci-failure PR has at least one CI failure and removed needs-rebase This Pull Request needs to be rebased ci-failure PR has at least one CI failure labels Sep 23, 2024
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Oct 4, 2024
@reidliu41 reidliu41 force-pushed the add_sys_prompt_to_config branch from 5716d1a to 3a9fd87 Compare October 20, 2024 03:43
@mergify mergify bot added testing Relates to testing and removed ci-failure PR has at least one CI failure labels Oct 20, 2024
@reidliu41 reidliu41 requested a review from a team February 1, 2025 12:57
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Feb 4, 2025
@booxter booxter mentioned this pull request Feb 4, 2025
Closed
@reidliu41
Copy link
Contributor Author

reidliu41 commented Feb 12, 2025

hi team, can someone take a look?

@mairin
Copy link
Member

mairin commented Feb 12, 2025

@reidliu41 it looks like it's blocked because @cdoern and @alimaredia requested changes... are those still applicable?

@reidliu41
Copy link
Contributor Author

reidliu41 commented Feb 12, 2025

thanks, yeah, so if someone has time, might help to review..

@booxter booxter dismissed stale reviews from alimaredia and cdoern February 19, 2025 00:31

Addressed I believe.

@booxter booxter mentioned this pull request Feb 24, 2025
Closed
@courtneypacheco courtneypacheco added the hold In-progress PR. Tag should be removed before merge. label Mar 6, 2025
@courtneypacheco
Copy link
Contributor

courtneypacheco commented Mar 6, 2025

Hey @reidliu41!

A PR was opened recently that is similar to yours: #3197

The difference is that PR focuses on decoupling the notion of hardcoding the specific model for each different workflow (training, sdg, eval, etc). Can you take a look?

@reidliu41
Copy link
Contributor Author

reidliu41 commented Mar 7, 2025

I think #3197 is not related to system_prompt in chat, please correct me if I misunderstood, @RobotSail

@RobotSail
Copy link
Member

RobotSail commented Mar 7, 2025

Hi @reidliu41,

The way that ilab works today requires us to hardcode settings for each part of the workflow, and this doesn't scale well when we want to adjust which model we use.

Going forward, the way we'll want configs to work is by having a models section which defines some model-specific settings like for instance the default system prompt. You can see in the lines your PR is changing, the way it works is by trying to auto-detect which model is being used on the backend and selecting the optimal prompt for that model.

In order to bring in the newer system, we will need to have the existing logic still live there since we can't just delete it.

I'm not against having a setting for system_prompt, but this will complicate that integration.

I would suggest that we either convert this PR to not have the system_prompt live in the config for now and simply live as a CLI argument --system-prompt which acts as the primary override, or wait until #3197 to land and then consider how the config will work afterwards.

@reidliu41
Copy link
Contributor Author

reidliu41 commented Mar 7, 2025

@RobotSail thank you so much for your explanation. It's good to wait for #3197 finish.

@RobotSail
Copy link
Member

RobotSail commented Apr 10, 2025

@reidliu41 We should rebase onto the new main and update this PR

@reidliu41 reidliu41 force-pushed the add_sys_prompt_to_config branch from 58f4060 to 1eba6d7 Compare April 10, 2025 08:06
@reidliu41
add --system-prompt for chat
e62e273 
- add a new feature to custom system prompt for chat response

Signed-off-by: reidliu41 <[email protected]>
@reidliu41 reidliu41 force-pushed the add_sys_prompt_to_config branch from 1eba6d7 to e62e273 Compare April 13, 2025 08:23
@reidliu41
Copy link
Contributor Author

reidliu41 commented Apr 13, 2025

@RobotSail updated

@github-actions
Copy link

github-actions bot commented Jun 13, 2025

This pull request has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Jun 13, 2025
@github-actions
Copy link

github-actions bot commented Jul 13, 2025

This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it!

@github-actions github-actions bot closed this Jul 13, 2025
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobotSail RobotSail RobotSail approved these changes

@alimaredia alimaredia Awaiting requested review from alimaredia

@cdoern cdoern Awaiting requested review from cdoern

@nathan-weinberg nathan-weinberg Awaiting requested review from nathan-weinberg

@jaideepr97 jaideepr97 Awaiting requested review from jaideepr97

@leseb leseb Awaiting requested review from leseb

+1 more reviewer

@booxter booxter booxter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hold In-progress PR. Tag should be removed before merge. one-approval PR has one approval from a maintainer stale testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@reidliu41 @mairin @courtneypacheco @RobotSail @booxter @leseb @alimaredia @jaideepr97 @cdoern @nathan-weinberg