Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add a process remove record command #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
May 1, 2025
Merged

feat: add a process remove record command #3117

mergify merged 1 commit into from
May 1, 2025

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Feb 2, 2025 •
edited
Loading

Issue resolved by this Pull Request:
Resolves ##3083

$ ilab process remove --help
Usage: ilab process remove [OPTIONS] PROCESS_UUID

  Remove process with uuid from ilab process list.

Options:
  -f, --force  Used to forcefully remove processes. Use with caution as it
               permanently deletes process without further confirmation.
  --help       Show this message and exit.


$  ilab process prune --help
Usage: ilab process prune [OPTIONS]

  Batch clean up filtered processes from ilab process list.

Options:
  --older INTEGER                 The day older than the specified number of
                                  days. Use 0 to remove all.
  --state [Running|Done|Errored]  Remove processes with the specified state.
  -f, --force                     Used to forcefully remove processes. Use
                                  with caution as it permanently deletes
                                  process without further confirmation.
  --help                          Show this message and exit.

$ ilab process remove 061f1b74-de49-11ef-9f60-0e8fd46a6638
Are you sure you want to remove process record?
The remove list: ['061f1b74-de49-11ef-9f60-0e8fd46a6638'] [y/N]: y
INFO 2025-02-02 22:50:18,600 instructlab.process.process:448: Process with UUID 061f1b74-de49-11ef-9f60-0e8fd46a6638 removed.
Removed 1 process records.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added testing Relates to testing ci-failure PR has at least one CI failure labels Feb 2, 2025
@reidliu41 reidliu41 requested a review from a team February 2, 2025 16:47
@jaideepr97 jaideepr97 linked an issue Feb 3, 2025 that may be closed by this pull request
Remove old processes from ilab process list #3083
Closed
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from 361c076 to 9b6d118 Compare February 4, 2025 07:09
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Feb 4, 2025
jaideepr97
jaideepr97 reviewed Feb 4, 2025
View reviewed changes
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from 9b6d118 to 403b0c5 Compare February 4, 2025 14:58
booxter
booxter suggested changes Feb 4, 2025
View reviewed changes
@booxter
Copy link
Contributor

booxter commented Feb 4, 2025

This will have to be rebased and rewritten a bit to confirm with the new Process / ProcessRegistry classes. #3050

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

This pull request has merge conflicts that must be resolved before it can be merged. @reidliu41 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase This Pull Request needs to be rebased label Feb 5, 2025
@booxter
Copy link
Contributor

booxter commented Feb 5, 2025

One question: this item assumes that #3081 is implemented (the main goal for pruning / removal is to clean up the list of completed processes that will grow after 3081 is done). Do you plan to work on #3081 ? I think it makes sense to do 3081 first, then this PR. What do you think?

@reidliu41
Copy link
Contributor Author

reidliu41 commented Feb 5, 2025

One question: this item assumes that #3081 is implemented (the main goal for pruning / removal is to clean up the list of completed processes that will grow after 3081 is done). Do you plan to work on #3081 ? I think it makes sense to do 3081 first, then this PR. What do you think?

Sure, I will take it too..

@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from 403b0c5 to 469b08b Compare February 17, 2025 03:00
@mergify mergify bot added ci-failure PR has at least one CI failure and removed needs-rebase This Pull Request needs to be rebased labels Feb 17, 2025
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from b130f39 to 47fec75 Compare February 17, 2025 03:04
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Feb 17, 2025
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from 47fec75 to ce7af64 Compare February 17, 2025 03:18
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Feb 17, 2025
@reidliu41
Copy link
Contributor Author

reidliu41 commented Feb 17, 2025 •
edited
Loading 

  py311-functional: install_deps> python -I -m pip install -r requirements-dev.txt
  Looking in indexes: https://pypi.org/simple, https://download.pytorch.org/whl/cpu
  WARNING: pytest-cov 6.0.0 does not provide the extra 'toml'
  Collecting boto3>=1.35.96 (from -r /Users/runner/work/instructlab/instructlab/requirements.txt (line 3))
    error: subprocess-exited-with-error
    Using cached boto3-1.36.21-py3-none-any.whl.metadata (6.7 kB)
   
  Using cached requests_toolbelt-1.0.0-py2.py3-none-any.whl (54 kB)
  Using cached tifffile-2025.1.10-py3-none-any.whl (227 kB)
  Building wheels for collected packages: tesserocr
    Building wheel for tesserocr (pyproject.toml): started
    Building wheel for tesserocr (pyproject.toml): finished with status 'error'
  Failed to build tesserocr
  py311-functional: exit 1 (48.88 seconds) /Users/runner/work/instructlab/instructlab> python -I -m pip install -r requirements-dev.txt pid=6418
  
    py311-unitcov: FAIL code 1 (90.66 seconds)
    py311-functional: FAIL code 1 (49.25 seconds)
    evaluation failed :( (139.99 seconds)

@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from ce7af64 to 040e3c7 Compare February 17, 2025 03:51
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Feb 17, 2025
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from 040e3c7 to e01c526 Compare February 17, 2025 06:58
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Feb 17, 2025
@booxter booxter mentioned this pull request Feb 24, 2025
Closed
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from e01c526 to a3ecb24 Compare March 4, 2025 15:52
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Mar 4, 2025
booxter
booxter suggested changes Mar 6, 2025
View reviewed changes
src/instructlab/process/process.py
process_records_to_remove.append(item_uuid)
continue

if older:
Copy link
Contributor

@booxter booxter Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ever not True at this point?

@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from a3ecb24 to cb898a5 Compare March 7, 2025 11:06
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Mar 7, 2025
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from 3fe0b64 to 15dd135 Compare March 7, 2025 11:58
@mergify mergify bot added the ci-failure PR has at least one CI failure label Mar 7, 2025
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from a6b5de8 to 2a78d84 Compare March 7, 2025 12:35
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Mar 7, 2025
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from 2a78d84 to 275a74d Compare March 7, 2025 12:59
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Mar 7, 2025
@reidliu41 reidliu41 requested a review from booxter March 7, 2025 23:15
booxter
booxter reviewed Mar 10, 2025
View reviewed changes
@booxter
Copy link
Contributor

booxter commented Mar 10, 2025

I think this is mostly ready for approval. Just some minor issues that are worth being picked up before we do merge. Thanks a lot for quick turnaround on reviews!

@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from 275a74d to 6e3ccd6 Compare March 10, 2025 15:24
@reidliu41
feat: add a process remove command
4d9295a 
- add remove and prune cmd, and update list

Signed-off-by: reid_liu <[email protected]>
@reidliu41 reidliu41 force-pushed the add-process-remove-cmd branch from 6e3ccd6 to 4d9295a Compare March 10, 2025 15:28
@mergify mergify bot added one-approval PR has one approval from a maintainer ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Mar 10, 2025
@booxter booxter requested a review from jaideepr97 April 16, 2025 19:42
@booxter booxter requested review from a team and removed request for jaideepr97 April 30, 2025 23:53
@mergify mergify bot merged commit 4448ac1 into instructlab:main May 1, 2025
29 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaideepr97 jaideepr97 jaideepr97 left review comments

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

+1 more reviewer

@booxter booxter booxter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove old processes from ilab process list

4 participants

@reidliu41 @booxter @jaideepr97 @nathan-weinberg