feat: add --state option to filter process list output #3125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e80fb72 to
9ad7250
Compare
booxter
suggested changes
Feb 6, 2025
| start_time_str, "%Y-%m-%d %H:%M:%S" | ||
| ).isoformat(), | ||
| "status": ILAB_PROCESS_STATUS.DONE, | ||
| } |
Contributor
There was a problem hiding this comment.
(Note to myself, no change required) This code should be re-written to use ProcessRegistry class to manage the state.
reidliu41
commented
Feb 6, 2025
reidliu41
commented
Feb 6, 2025
9ad7250 to
7822ae3
Compare
2802065 to
01a4a47
Compare
46478ff to
3c29e28
Compare
booxter
reviewed
Feb 7, 2025
Signed-off-by: reid_liu <[email protected]>
3c29e28 to
29c63d5
Compare
ae9d63f to
d4b5c49
Compare
d4b5c49 to
b0b02ad
Compare
b0b02ad to
d602a94
Compare
Contributor
Author
|
seems random failed for the functional test script.. |
d602a94 to
9355710
Compare
Signed-off-by: reid_liu <[email protected]>
booxter
approved these changes
Feb 9, 2025
Contributor
booxter
left a comment
There was a problem hiding this comment.
Oh you actually went ahead and enum-ed! Thanks!!!
RobotSail
approved these changes
Feb 16, 2025
mergify bot
added a commit
that referenced
this pull request
Feb 26, 2025
Since #3125 merged, so updated it. **Checklist:** - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. Approved-by: booxter Approved-by: nathan-weinberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved by this Pull Request:
Resolves #3081
Checklist:
conventional commits.