Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Feb 7, 2025

We'd like to see if disabling spell check will make us agregeously
ilitarate. ;) If the experiment doesn't go well, we can revert this
patch later.

This is a follow-up to #3130

Signed-off-by: Ihar Hrachyshka [email protected]

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

We'd like to see if disabling spell check will make us agregeously
ilitarate. ;) If the experiment doesn't go well, we can revert this
patch later.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@mergify mergify bot added the CI/CD Affects CI/CD configuration label Feb 7, 2025
@booxter booxter mentioned this pull request Feb 7, 2025
6 tasks
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the one-approval PR has one approval from a maintainer label Feb 10, 2025
Copy link
Contributor

@jwm4 jwm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea.

@courtneypacheco
Copy link
Contributor

I think this is a good compromise and would like to go ahead with merging this change. I want others to give their feedback though, so I won't formally approve it until others have had the chance to weigh in.

@courtneypacheco courtneypacheco added the hold In-progress PR. Tag should be removed before merge. label Feb 11, 2025
Copy link
Contributor

@courtneypacheco courtneypacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this PR and putting a hold for now until others can chime in. If everyone is ok with this by Friday, we can remove the hold and merge it.

@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Feb 11, 2025
@booxter booxter removed the hold In-progress PR. Tag should be removed before merge. label Feb 14, 2025
@mergify mergify bot merged commit 53f7e5c into instructlab:main Feb 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants