Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Temporarily cap trl to avoid breaking changes from being consumed #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Feb 19, 2025
Merged

fix: Temporarily cap trl to avoid breaking changes from being consumed #3167

mergify merged 1 commit into from
Feb 19, 2025

Conversation

@courtneypacheco
Copy link
Contributor

@courtneypacheco courtneypacheco commented Feb 19, 2025 •
edited
Loading

Issue resolved by this Pull Request:
Resolves #3155

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

Overview

This pull request should resolve the following bug seen in main:

Image

The above screenshot was taken from this job URL: https://github.com/instructlab/instructlab/actions/runs/13371561460/job/37341408190?pr=3148

See linked issue for more details.

@mergify mergify bot added the dependencies Relates to dependencies label Feb 19, 2025
@courtneypacheco courtneypacheco marked this pull request as ready for review February 19, 2025 01:10
@mergify mergify bot added one-approval PR has one approval from a maintainer ci-failure PR has at least one CI failure labels Feb 19, 2025
@courtneypacheco courtneypacheco force-pushed the fix-trl-dependency-issue branch from 5cbd677 to a731240 Compare February 19, 2025 01:46
@mergify mergify bot added documentation Improvements or additions to documentation ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Feb 19, 2025
@courtneypacheco courtneypacheco force-pushed the fix-trl-dependency-issue branch from a731240 to ed48f98 Compare February 19, 2025 02:03
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Feb 19, 2025
@bbrowning bbrowning mentioned this pull request Feb 19, 2025
Closed
@mergify mergify bot merged commit 9138eb4 into main Feb 19, 2025
29 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Feb 19, 2025
@mergify mergify bot deleted the fix-trl-dependency-issue branch February 19, 2025 15:44
@booxter booxter mentioned this pull request Feb 19, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdoern cdoern cdoern approved these changes

+1 more reviewer

@booxter booxter booxter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Relates to dependencies documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: Temporarily cap trl<0.15.0 to ensure trl breaking changes aren't consumed

4 participants

@courtneypacheco @booxter @cdoern