tests: fix failure due to a slight difference in HF exception message #3177
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoern
approved these changes
Feb 21, 2025
The observed message in CI run is: `401 Client Error: Unauthorized for url: ...` (note the `:` character instead of a dot) Note: in general it's a bad idea to assume a particular message is returned, but leaving dealing with improving the test case for when CI is fixed. Signed-off-by: Ihar Hrachyshka <[email protected]>
f5a0439 to
3b33997
Compare
Contributor
Author
|
Rebased because I suspect the CI job hasn't picked up the |
reidliu41
approved these changes
Feb 21, 2025
courtneypacheco
approved these changes
Feb 24, 2025
Contributor
|
@Mergifyio backport release-v0.24 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
courtneypacheco
added a commit
that referenced
this pull request
Feb 24, 2025
…-3177 tests: fix failure due to a slight difference in HF exception message (backport #3177)
Contributor
|
@mergify backport release-v0.23 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
mergify bot
added a commit
that referenced
this pull request
Mar 3, 2025
… (backport #3177) (#3210) The observed message in CI run is: `401 Client Error: Unauthorized for url: ...` (note the `:` character instead of a dot) Note: in general it's a bad idea to assume a particular message is returned, but leaving dealing with improving the test case for when CI is fixed. Signed-off-by: Ihar Hrachyshka <[email protected]> **Checklist:** - [x] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. <hr>This is an automatic backport of pull request #3177 done by [Mergify](https://mergify.com). Approved-by: courtneypacheco Approved-by: ktdreyer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The observed message in CI run is:
401 Client Error: Unauthorized for url: ...(note the
:character instead of a dot)Note: in general it's a bad idea to assume a particular message is
returned, but leaving dealing with improving the test case for when CI
is fixed.
Signed-off-by: Ihar Hrachyshka [email protected]
Checklist:
conventional commits.