infra: fix cloud-instance ec2 wait loop #3186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, "./cloud-instance.sh ec2 launch" would fail to print information about the host it was launching. Bash with set -e will bail out on (( $i++ )) when $i is zero. Start i on 1 to avoid this. This also clarifies that this is the "first" logical time the script has polled describe-instances before sleeping. Signed-off-by: Ken Dreyer <[email protected]>
booxter
approved these changes
Feb 25, 2025
courtneypacheco
approved these changes
Feb 25, 2025
mergify bot
added a commit
that referenced
this pull request
Feb 26, 2025
The files in [`scripts/infra`](https://github.com/instructlab/instructlab/tree/main/scripts/infra) are relevant to CI/CD. Make PRs easier to discover for people who work on CI/CD. With this change, my recent PR #3186 would get the [CI/CD label](https://github.com/instructlab/instructlab/pulls?q=is%3Aopen+is%3Apr+label%3ACI%2FCD). Approved-by: booxter Approved-by: courtneypacheco
Contributor
Author
|
@mergify backport release-v0.24 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
added a commit
that referenced
this pull request
Feb 27, 2025
Prior to this change, `./cloud-instance.sh ec2 launch` would fail to print information about the host it was launching. Bash with `set -e` will bail out on `(( $i++ ))` when `$i` is zero. Start `i` on `1` to avoid this. This also clarifies that this is the "first" logical time the script has polled `describe-instances` before sleeping. **Issue resolved by this Pull Request:** Resolves #3185 <hr>This is an automatic backport of pull request #3186 done by [Mergify](https://mergify.com). Approved-by: booxter Approved-by: danmcp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
./cloud-instance.sh ec2 launchwould fail to print information about the host it was launching.Bash with
set -ewill bail out on(( $i++ ))when$iis zero. Startion1to avoid this. This also clarifies that this is the "first" logical time the script has polleddescribe-instancesbefore sleeping.Issue resolved by this Pull Request:
Resolves #3185