Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle INSTANCE_ID and details support for IBM Cloud and add rename m… #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Mar 2, 2025
Merged

Handle INSTANCE_ID and details support for IBM Cloud and add rename m… #3205

mergify merged 1 commit into from
Mar 2, 2025

Conversation

@danmcp
Copy link
Member

@danmcp danmcp commented Feb 28, 2025 •
edited
Loading

…ethod for ec2 and ibm

PR includes:

  • Adding INSTANCE_ID support for ibm cloud
    • Rename _get_instances to _get_ec2_instances since it is specific to ec2
  • Add details support for ibm cloud
  • Add rename support for ibm and ec2
  • Fix usage of EC2_INSTANCE_TYPE in launch echo

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

booxter
booxter approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed for EC2 it works. For IBM, only read the code and it seems to make sense.

@mergify mergify bot added the one-approval PR has one approval from a maintainer label Feb 28, 2025
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Mar 2, 2025
@danmcp danmcp removed the request for review from ktdreyer March 2, 2025 19:22
@mergify mergify bot merged commit a248d2a into instructlab:main Mar 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@courtneypacheco courtneypacheco courtneypacheco approved these changes

+1 more reviewer

@booxter booxter booxter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danmcp @booxter @courtneypacheco