infra: cloud-instance.sh improvements #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When choosing the latest KERNEL_VERSION to build the nvidia driver, select the kernel package that has the most recent build time. This integer is easy to sort, and we avoid kernel version string sorting nuances. Signed-off-by: Ken Dreyer <[email protected]>
Contributor
Author
|
Here is the set of commands I use to test this. I'm using |
When you specify multiple packages to DNF in RHEL 9, if some are available and some are missing, DNF will print a warning and continue on. As a result, the install-nvidia.sh script can proceed without installing all dependencies, and when the user reboots, the nvidia drivers may not function. Reconfigure DNF to error on any missing packages. This helps us catch problems sooner. Combine the two dnf config-manager commands into one invocation at the top of the script so the settings take effect for all subsequent DNF operations. Remove the "--best --nodocs" options, because they only affect dnf install operations, not config-manager. Signed-off-by: Ken Dreyer <[email protected]>
booxter
approved these changes
Mar 4, 2025
danmcp
reviewed
Mar 4, 2025
This script can fail at various points. We want the user to have this piece of debugging information if that happens. Signed-off-by: Ken Dreyer <[email protected]>
This script handles multiple kernels transparently now, so we should not uninstall them. Advise users to update to the latest kernel instead. Signed-off-by: Ken Dreyer <[email protected]>
We only want to compute KERNEL_VERSION if the user has not already set that variable (in other words, it is not null/empty). In Bash, we can use -z to test if a string is null/empty. Signed-off-by: Ken Dreyer <[email protected]>
booxter
approved these changes
Mar 4, 2025
danmcp
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves kernel and package handling for
cloud-instance.sh.