refactor: use CUDA_HOME var when applicable #3249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneypacheco
approved these changes
Mar 28, 2025
Contributor
courtneypacheco
left a comment
There was a problem hiding this comment.
Looks good. Do we also want to update this? -> https://github.com/instructlab/instructlab/blob/main/docs/accelerators/gpu-acceleration.md?plain=1#L124
we had some docs and CI config that were using hardcoded values rather than an existing var this commit makes those configs use the CUDA_HOME var Signed-off-by: Nathan Weinberg <[email protected]>
d989095 to
3ddce3b
Compare
booxter
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had some docs and CI config that were using
hardcoded values rather than an existing var
this commit makes those configs use the CUDA_HOME var
Checklist:
conventional commits.