-
Notifications
You must be signed in to change notification settings - Fork 450
feat: add model family in cfg #3255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fd8f505 to
f03672e
Compare
f03672e to
9221c50
Compare
9221c50 to
5fe5d83
Compare
5fe5d83 to
f54f607
Compare
f54f607 to
0b55bf3
Compare
0b55bf3 to
6ccd1cd
Compare
6ccd1cd to
8681f1e
Compare
Signed-off-by: Jaideep Rao <[email protected]>
8681f1e to
ffebea4
Compare
ffebea4 to
dc8f7ea
Compare
dc8f7ea to
94ba0ff
Compare
94ba0ff to
90422f7
Compare
90422f7 to
60eb3bd
Compare
60eb3bd to
b93b666
Compare
b93b666 to
0d3a521
Compare
RobotSail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work on this @jaideepr97
0d3a521 to
dbfd4bb
Compare
cdoern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the few nits left over, LGTM
Signed-off-by: Jaideep Rao <[email protected]>
dbfd4bb to
9496ea7
Compare
booxter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through the comments. This looks ready.
adds the ability to pass a specific model-id to generate, chat and serve. This model id is then resolved out of the config if found, and details like the model-family, path etc are extracted and passed further
This is required to support 3rd party models being used as students, teachers etc in an easy way. The model family value is passed into sdg and appropriate chat template is selected based on what is passed
Checklist:
conventional commits.