[backport] fix: Update model_generate to output logits
#3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 'logits'` We need to force `moded_generate` to output logits so that `linux_train.py` can reference the `logits` attribute Signed-off-by: Courtney Pacheco <[email protected]>
Contributor
Author
|
Needs this backport to be merged first: #3262 |
|
This pull request has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days. |
Contributor
|
We are disabling the small job for linux-train and won't do any fixes going forward for the code path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
conventional commits.
We need to force
moded_generateto output logits so thatlinux_train.pycan reference thelogitsattribute. Otherwise, we run into an issue in our sister repos, likeinstructlab/sdg. For example, see instructlab/sdg#595 failing due to this issue: https://github.com/instructlab/sdg/actions/runs/14317698278/job/40169189831?pr=595The following commit on
mainresolved the above issue: 8fe9bc6Evidence that instructlab/sdg#595 passed:
instructlab/sdg#595