Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Apr 9, 2025

This is on the path to fix MacOS tests and the gate. It doesn't enable MacOS tests, yet, because functional tests are still failing.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added CI/CD Affects CI/CD configuration testing Relates to testing dependencies Relates to dependencies labels Apr 9, 2025
@mergify mergify bot added one-approval PR has one approval from a maintainer ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 9, 2025
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Apr 9, 2025
@booxter booxter force-pushed the instructlab-kerfuffle branch from 897acf0 to c9cf2a2 Compare April 9, 2025 17:14
booxter added 3 commits April 9, 2025 13:14
This reverts commit ae16698.

Signed-off-by: Ihar Hrachyshka <[email protected]>
These are not ignored, as one could expect from a shell code.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@booxter booxter force-pushed the instructlab-kerfuffle branch from c9cf2a2 to ea6216a Compare April 9, 2025 17:15
@booxter booxter changed the title Fix MacOS / docling / revert training bump that broke functional tests Fix MacOS test run; re-introduce the docling fix; fix DISABLE_GPU_ACCELERATION setting via GITHUB_ENV file Apr 9, 2025
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 9, 2025
@booxter booxter force-pushed the instructlab-kerfuffle branch from 2eebbf4 to 5a0b454 Compare April 9, 2025 18:57
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Apr 9, 2025
@booxter booxter changed the title Fix MacOS test run; re-introduce the docling fix; fix DISABLE_GPU_ACCELERATION setting via GITHUB_ENV file re-introduce the docling fix; fix DISABLE_GPU_ACCELERATION setting via GITHUB_ENV file Apr 9, 2025
@mergify mergify bot merged commit 12b1217 into instructlab:main Apr 9, 2025
29 checks passed
@courtneypacheco
Copy link
Contributor

@mergify backport release-v0.23

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

backport release-v0.23

✅ Backports have been created

Details

@courtneypacheco
Copy link
Contributor

@mergify backport release-v0.24

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

backport release-v0.24

✅ Backports have been created

Details

mergify bot added a commit that referenced this pull request Apr 14, 2025
…a GITHUB_ENV file (backport #3271) (#3277)

This is on the path to fix MacOS tests and the gate. It doesn't enable MacOS tests, yet, because functional tests are still failing.











**Checklist:**

- [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the
  [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary).
- [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release.
- [ ] Documentation has been updated, if necessary.
- [ ] Unit tests have been added, if necessary.
- [ ] Functional tests have been added, if necessary.
- [ ] E2E Workflow tests have been added, if necessary.
<hr>This is an automatic backport of pull request #3271 done by [Mergify](https://mergify.com).


Approved-by: ktdreyer

Approved-by: booxter
mergify bot added a commit that referenced this pull request Apr 15, 2025
…a GITHUB_ENV file (backport #3271) (#3276)

This is on the path to fix MacOS tests and the gate. It doesn't enable MacOS tests, yet, because functional tests are still failing.











**Checklist:**

- [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the
  [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary).
- [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release.
- [ ] Documentation has been updated, if necessary.
- [ ] Unit tests have been added, if necessary.
- [ ] Functional tests have been added, if necessary.
- [ ] E2E Workflow tests have been added, if necessary.
<hr>This is an automatic backport of pull request #3271 done by [Mergify](https://mergify.com).


Approved-by: ktdreyer

Approved-by: booxter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration dependencies Relates to dependencies testing Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants