Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Bump SDG version to ensure the latest docling changes are consumed #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
courtneypacheco merged 1 commit into from
Apr 10, 2025
Merged

chore: Bump SDG version to ensure the latest docling changes are consumed #3281

courtneypacheco merged 1 commit into from
Apr 10, 2025

Conversation

@courtneypacheco
Copy link
Contributor

@courtneypacheco courtneypacheco commented Apr 10, 2025 •
edited
Loading

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

Before we cut a release, we should bump the SDG version in the requirements.txt file to ensure that SDG's latest release, which contains important docling bugfixes, gets consumed.

@courtneypacheco
Bump SDG version to ensure the latest docling changes are consumed
8d791aa 
Bump the SDG version in the `requirements.txt` file to ensure that SDG's latest release, which contains important docling bugfixes, gets consumed.

Signed-off-by: Courtney Pacheco <[email protected]>
@mergify mergify bot added the dependencies Relates to dependencies label Apr 10, 2025
@ktdreyer
Copy link
Contributor

ktdreyer commented Apr 10, 2025

We intend to backport this to release-v0.23 and abandon release-v0.24, right?

@courtneypacheco courtneypacheco marked this pull request as ready for review April 10, 2025 16:00
@courtneypacheco
Copy link
Contributor Author

courtneypacheco commented Apr 10, 2025

@ktdreyer I want to ensure that instructlab-sdg==0.7.3 still runs on main after the recent updates to our CI. instructlab-sdg==0.7.3 was last tested before the CI broke earlier this week. Now that it's fixed again, I want to validate it once more.

@mergify mergify bot added the one-approval PR has one approval from a maintainer label Apr 10, 2025
@courtneypacheco
Copy link
Contributor Author

courtneypacheco commented Apr 10, 2025 •
edited
Loading

Merging this to create a new release. We will need to update the approval permissions in the future to only require 1 in these situations.

@courtneypacheco courtneypacheco merged commit 5adac3c into main Apr 10, 2025
28 checks passed
@courtneypacheco courtneypacheco deleted the bump-sdg-min-version branch April 10, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danmcp danmcp danmcp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Relates to dependencies one-approval PR has one approval from a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@courtneypacheco @ktdreyer @danmcp