fix(ci): Fix linux_train.py "logits" failure
#3284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e08dad to
2ca3b10
Compare
2ca3b10 to
8af5e34
Compare
8af5e34 to
c5c4d75
Compare
c5c4d75 to
64ddc93
Compare
64ddc93 to
57bac27
Compare
57bac27 to
f8982d6
Compare
In certain situations, `linux_train.py` fails with: "UserWarning: `return_dict_in_generate` is NOT set to `True`, but `output_logits` is. When `return_dict_in_generate` is not `True`, `output_logits` is ignored." To fix this failure, I have added `return_dict_in_generate=True` as an input to `model.generate()`. Signed-off-by: Courtney Pacheco <[email protected]>
f8982d6 to
b0cd529
Compare
Member
|
@courtneypacheco We have a PR to fix this in #3264 |
Contributor
|
Please link to #3289 if you intend to continue on this PR to fix the issue in linux-train flow. |
Contributor
|
CI issue should be addressed with #3307 I believe. If we still have issues with the job, please reopen and refresh the patch. For now, I'm closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
conventional commits.
In certain situations,
linux_train.pyfails with: "UserWarning:return_dict_in_generateis NOT set toTrue, butoutput_logitsis. Whenreturn_dict_in_generateis notTrue,output_logitsis ignored."To fix this failure, I have added
return_dict_in_generate=Trueas an input tomodel.generate().