Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Apr 16, 2025

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@mergify mergify bot added CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation testing Relates to testing labels Apr 16, 2025
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Apr 16, 2025
@booxter booxter requested a review from a team April 17, 2025 18:02
@nathan-weinberg
Copy link
Member

Motivation?

@RobotSail
Copy link
Member

@nathan-weinberg There are a number of features we use in Python3.11 that are not present in 3.10 so we'll often need to introduce compatibility logic to maintain it. It doesn't seem like there is a strong need to maintain support for 3.10 given that the upgrade to 3.11 is very seamless. Unless there is a pressing concern for something working on Python 3.10 that I'm not aware of, we should aim to move off of it sooner than later.

@nathan-weinberg
Copy link
Member

Makes sense to me 👍

@mergify mergify bot merged commit 3d78209 into instructlab:main Apr 17, 2025
31 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation testing Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants