Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: change to using dict instead of model_info class #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaideepr97 wants to merge 1 commit into from
Closed

chore: change to using dict instead of model_info class #3294

jaideepr97 wants to merge 1 commit into from

Conversation

@jaideepr97
Copy link
Member

@jaideepr97 jaideepr97 commented Apr 17, 2025 •
edited
Loading

using a custom class model_info to represent 3rd party model info seems to not play well with ruamel yaml representation anytime the config object needs to be dumped either to file or stdout leading to a yaml representation error.

ruamel.yaml.representer.RepresenterError: cannot represent an object: id='llama-3.3' family='meta-llama' path='/home/tmp/tmp.Gbn8Eel5PD/.cache/instructlab/models/meta-llama/Llama-3.3-70B-Instruct/' system_prompt=None

This seems to be happening because we load a list of model_info objects into memory rather than just the model_info object directly like for the other fields

It's easier to just work with a list of dicts instead

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added testing Relates to testing ci-failure PR has at least one CI failure labels Apr 17, 2025
@jaideepr97 jaideepr97 force-pushed the fix-yaml-represented branch from f03b14f to 3d8c34b Compare April 17, 2025 13:29
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Apr 17, 2025
@github-actions
Copy link

github-actions bot commented Apr 17, 2025

E2E (NVIDIA L40S x4) LLAMA workflow launched on this PR: View run

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

e2e workflow failed on this PR: View run, please investigate.

@mergify mergify bot added the ci-failure PR has at least one CI failure label Apr 17, 2025
@github-actions
Copy link

github-actions bot commented Apr 17, 2025

E2E (NVIDIA L40S x4) LLAMA workflow launched on this PR: View run

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

e2e workflow failed on this PR: View run, please investigate.

@jaideepr97 jaideepr97 force-pushed the fix-yaml-represented branch from 3d8c34b to cfe26a6 Compare April 17, 2025 13:56
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Apr 17, 2025
@jaideepr97 jaideepr97 force-pushed the fix-yaml-represented branch from cfe26a6 to 9abaf8b Compare April 17, 2025 14:08
@github-actions
Copy link

github-actions bot commented Apr 17, 2025

E2E (NVIDIA L40S x4) LLAMA workflow launched on this PR: View run

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

e2e workflow failed on this PR: View run, please investigate.

ktdreyer
ktdreyer reviewed Apr 17, 2025
View reviewed changes
src/instructlab/configuration.py Outdated
yaml.indent(mapping=2, sequence=4, offset=2)

# yaml.representer.add_representer(BaseModel, lambda r, d: r.represent_dict(d.model_dump()))

Copy link
Contributor

@ktdreyer ktdreyer Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this some debugging code?

Copy link
Member Author

@jaideepr97 jaideepr97 Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yeah leftover from a different approach i was trying first

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

E2E (NVIDIA L40S x4) LLAMA workflow launched on this PR: View run

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

e2e workflow failed on this PR: View run, please investigate.

@mergify mergify bot added the ci-failure PR has at least one CI failure label Apr 17, 2025
@jaideepr97 jaideepr97 force-pushed the fix-yaml-represented branch from 9abaf8b to 4390e17 Compare April 17, 2025 14:52
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Apr 17, 2025
@jaideepr97 jaideepr97 marked this pull request as ready for review April 17, 2025 14:53
@jaideepr97 jaideepr97 force-pushed the fix-yaml-represented branch from 4390e17 to f5d40ba Compare April 17, 2025 15:18
@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 17, 2025
booxter
booxter suggested changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@booxter booxter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal because we lose comments. There's no reason for us not to handle this scenario properly. So I'd rather fix our code that converts configMap to dict for ruamel to handle iterables of models instead. I'll send a fix in a few. Stand by.

@booxter booxter added the hold In-progress PR. Tag should be removed before merge. label Apr 17, 2025
@booxter
Copy link
Contributor

booxter commented Apr 17, 2025

Please see #3295

@mergify mergify bot added the ci-failure PR has at least one CI failure label Apr 17, 2025
@jaideepr97
Copy link
Member Author

jaideepr97 commented Apr 17, 2025

closing in favor of #3295

@jaideepr97 jaideepr97 closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktdreyer ktdreyer ktdreyer left review comments

@RobotSail RobotSail Awaiting requested review from RobotSail

@cdoern cdoern Awaiting requested review from cdoern

+1 more reviewer

@booxter booxter booxter requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-failure PR has at least one CI failure documentation Improvements or additions to documentation hold In-progress PR. Tag should be removed before merge. testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaideepr97 @booxter @ktdreyer