ci: Add e2e-nvidia-l40s-x4 job variant for python 3.12 #3296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
892796f to
5146844
Compare
We will need this job to validate that the switch to python 3.12 doesn't
break anything, particularly for dolomite training.
This is a verbatim copy of the original python3.11 job, but with the
following sed rule applied:
sed -i 's/python3.11/python3.12/g' {}
Signed-off-by: Ihar Hrachyshka <[email protected]>
5146844 to
a6acdbd
Compare
Contributor
|
If you push this branch to https://github.com/instructlab/instructlab , you can test it before merging |
Contributor
Author
|
I would like to merge it before the rest of python 3.12 work happens. We'll need this workflow during the development and it's less messy if we merge it now and unblock remaining work to happen in forks not in the main repo, which would pollute branch namespaces for all other users of the repo. |
Contributor
Author
|
@instructlab/core-maintainers I will need this workflow merged to continue working on python3.12 enablement. I'd like to see this merged before all remaining issues with python 3.12 are resolved. It should be safe to merge this because the workflow is not triggered automatically and is not required to merge patches. Please. |
nathan-weinberg
approved these changes
Apr 18, 2025
RobotSail
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need this job to validate that the switch to python 3.12 doesn't
break anything, particularly for dolomite training.
Signed-off-by: Ihar Hrachyshka [email protected]
Checklist:
conventional commits.