chore: Increase medium e2e instance size to g6.16xlarge
#3301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Courtney Pacheco <[email protected]>
booxter
reviewed
Apr 18, 2025
| github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }} | ||
| ec2-image-id: ${{ vars.AWS_EC2_AMI }} | ||
| ec2-instance-type: g6.8xlarge | ||
| ec2-instance-type: g6.16xlarge |
Contributor
There was a problem hiding this comment.
at the very least put a comment to revert it later; and link to #3298
That said, I don't think we should use bumps without first trying to collect some disk usage data on the node. I doubt the size of the disk is the actual problem with gguf writer. Having some monitoring / stats collection during job run that we could then dump to github logs and inspect would help here.
danmcp
reviewed
Apr 18, 2025
| github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }} | ||
| ec2-image-id: ${{ vars.AWS_EC2_AMI }} | ||
| ec2-instance-type: g6.8xlarge | ||
| ec2-instance-type: g6.16xlarge |
Member
There was a problem hiding this comment.
What's the intention of this change?
I assume it's to get more RAM for a larger tmp by default?
6 tasks
Member
|
No context? Are we spending money just for the sake of spending money? 😉 |
Contributor
|
I believe this is not relevant anymore. Feel free to reopen if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
conventional commits.