Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: respect global teacher id for generation (backport #3309) #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Apr 23, 2025
Merged

fix: respect global teacher id for generation (backport #3309) #3311

mergify merged 1 commit into from
Apr 23, 2025

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 23, 2025

missed adding logic to pick up teacher model id from config in earlier PR. This PR fixes that

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.
This is an automatic backport of pull request #3309 done by [Mergify](https://mergify.com).

@jaideepr97 @mergify
respect global teacher id for generation
6ea33e2 
Signed-off-by: Jaideep Rao <[email protected]>
(cherry picked from commit 8ea9979)
@mergify mergify bot mentioned this pull request Apr 23, 2025
Merged
6 tasks
@mergify mergify bot added the release-branch Pull Request directly to a release branch label Apr 23, 2025
@mergify mergify bot added one-approval PR has one approval from a maintainer ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 23, 2025
@mergify mergify bot merged commit efd9ddc into release-v0.26 Apr 23, 2025
28 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Apr 23, 2025
@mergify mergify bot deleted the mergify/bp/release-v0.26/pr-3309 branch April 23, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@courtneypacheco courtneypacheco courtneypacheco approved these changes

@jaideepr97 jaideepr97 jaideepr97 approved these changes

Assignees

No one assigned

Labels

release-branch Pull Request directly to a release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@courtneypacheco @jaideepr97