chore(deps): Bump minimum instructlab-training version
#3312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0883288 to
25f305d
Compare
25f305d to
dd30632
Compare
dd30632 to
a98b82b
Compare
a98b82b to
178c62c
Compare
178c62c to
d969b58
Compare
Contributor
|
The e2e-medium tests consistently fail with this PR. We also identified that e2e is failing on the training repo itself, instructlab/training#494 |
d969b58 to
b3e2d35
Compare
b3e2d35 to
3f5cabc
Compare
Contributor
|
e2e-medium CI fails with: We've triaged this failure to #3320 |
Contributor
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
3f5cabc to
cedaf89
Compare
Contributor
|
I think every minimal version bump should at least attempt to explain why it's needed. |
Contributor
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
cedaf89 to
07a81ce
Compare
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
07a81ce to
089fa33
Compare
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
Ensure that the latest version for `instructlab-training` is consumed: https://github.com/instructlab/training/releases/tag/v0.10.1 Signed-off-by: Courtney Pacheco <[email protected]> Signed-off-by: Charlie Doern <[email protected]>
089fa33 to
5b56fca
Compare
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
|
e2e workflow succeeded on this PR: View run, congrats! |
cdoern
approved these changes
Apr 30, 2025
Contributor
|
@Mergifyio backport |
Contributor
❌ No backport have been createdDetailsNo destination branches found |
ktdreyer
reviewed
Apr 30, 2025
|
|
||
| torch<2.7.0 | ||
| vllm<0.9.0 | ||
| vllm<0.9.0 No newline at end of file |
Contributor
There was a problem hiding this comment.
Presumably changing this line because it has the string "0.9.0" here, and the editor altered the newline on this file.
ktdreyer
approved these changes
Apr 30, 2025
|
e2e workflow succeeded on this PR: View run, congrats! |
Contributor
|
https://github.com/Mergifyio backport release-v0.26 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
conventional commits.
Ensure that the latest version for
instructlab-trainingis consumed: https://github.com/instructlab/training/releases/tag/v0.10.1