ci: Always collect df -h stats regardless of failure #3325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change, if test script failed, we couldn't check the final storage. This should help with investigation of: instructlab#3298 Signed-off-by: Ihar Hrachyshka <[email protected]>
Contributor
Author
|
I don't think CI will actually check the change before merging. @ktdreyer do I have to go through the main repo push and prove this will work, or is it obviously correct? |
Contributor
|
I've read the docs. I think it's worth testing this change in the |
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
JamesKunstle
approved these changes
Apr 29, 2025
|
e2e workflow succeeded on this PR: View run, congrats! |
RobotSail
approved these changes
Apr 30, 2025
Contributor
|
I understand we're moving fast here, and I still think its important to test new changes to GHA workflows. The impact of breaking these GHA workflows is high. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, if test script failed, we couldn't check the final
storage.
This should help with investigation of:
#3298
Signed-off-by: Ihar Hrachyshka [email protected]
Checklist:
conventional commits.