ci: enable workflow_dispatch for all e2e jobs, part 1 #3341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
45dd229 to
d962267
Compare
Contributor
|
There are two commits here, and one is largely un-dong the other. Is that intentional? Do you want to squash them down to a single change? |
This allows to test workflow changes to these jobs before merging them. Note: this change doesn't include more risky changes like adding inputs for pr number etc. This is intentional and will be done in a separate PR when the Run workflow button is available in the UI and we can test changes to workflows before merging. Signed-off-by: Ihar Hrachyshka <[email protected]>
d962267 to
9ee03b8
Compare
Contributor
Author
|
@ktdreyer it was some rebase mistake I made. Thanks for spotting and it warms my heart someone cares about spurious commits. :) |
ktdreyer
approved these changes
May 2, 2025
reidliu41
approved these changes
May 6, 2025
Contributor
|
https://github.com/Mergifyio backport release-v0.26 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
mergify bot
added a commit
that referenced
this pull request
May 16, 2025
#3409) This allows to test workflow changes to these jobs before merging them. Note: this change doesn't include more risky changes like adding inputs for pr number etc. This is intentional and will be done in a separate PR when the Run workflow button is available in the UI and we can test changes to workflows before merging. Signed-off-by: Ihar Hrachyshka <[email protected]> **Checklist:** - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. <hr>This is an automatic backport of pull request #3341 done by [Mergify](https://mergify.com). Approved-by: cdoern Approved-by: booxter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to test workflow changes to these jobs before merging them.
Note: this change doesn't include more risky changes like adding inputs
for pr number etc. This is intentional and will be done in a separate PR
when the Run workflow button is available in the UI and we can test
changes to workflows before merging.
Signed-off-by: Ihar Hrachyshka [email protected]
Checklist:
conventional commits.