-
Notifications
You must be signed in to change notification settings - Fork 450
test: add functionnal test to catch context too large #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add functionnal test to catch context too large #613
Conversation
|
@russellb 👋🏻 |
|
Can someone trigger the CI for this change? Thanks! |
|
Local run: |
The reason it isn't running is that This is the commit: 7ff733a |
3ca0fac to
a0b3aa1
Compare
After instructlab/instructlab#559, a new message was added in the chat when the context size is too small for both prompt and response. We now have a test that validates this behavior. Signed-off-by: Sébastien Han <[email protected]>
|
@leseb can you resolve the conflicts? |
Signed-off-by: Kai Xu <[email protected]>
|
I resolved the conflicts and all tests passed. |
After #559, a new message was added in the chat when the context size is too small for both prompt and response.
We now have a test that validates this behavior.