Use constraints-dev.txt in ilab e2e tests #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of instructlab/instructlab#3320 over to the SDG repository. While doing so, I noticed we also were not using "-DGGML_CUDA=ON" so updated that as well, since it's the same pip install line in the file. Signed-off-by: Ben Browning <[email protected]>
Contributor
Author
|
The e2e-medium passed in https://github.com/instructlab/sdg/actions/runs/14860110126/job/41722568009 testing with this change, so merging this to get CI green again. |
Contributor
Author
|
@Mergifyio backport release-v0.8 |
Contributor
✅ Backports have been createdDetails
|
bbrowning
added a commit
that referenced
this pull request
May 15, 2025
Use constraints-dev.txt in ilab e2e tests (backport #618)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of instructlab/instructlab#3320 over to the SDG repository. While doing so, I noticed we also were not using "-DGGML_CUDA=ON" so updated that as well, since it's the same pip install line in the file.