This repository was archived by the owner on Dec 22, 2018. It is now read-only.
update build script so that running with npm start works #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@KaneMorgan this still have the problem, not sure why you closed it |
|
It didn't seem like this was still under active development. From what I can remember the bug is just that its looking at the wrong directory in the script, it should be looking at the doc rather than the web directory. I started looking at this fork that someone else made https://github.com/DynamicEnvironmentSystems/pdf-annotate.js I'm not actively looking at this anymore but it does fix an issue with getting started so I'll reopen it. |
|
Kane Morgan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this addresses #19 but it may have been a different root cause looking at the dates