fix(renderFieldsOnly): use prettier config#23
Merged
stevenpetryk merged 2 commits intointercom:masterfrom Apr 16, 2020
Merged
Conversation
Contributor
|
Do you have a need for this to be ran through prettier? At Intercom we're only using this for some validation in CI, so we're trying to keep the runtime as quick as possible. Happy to merge if you have a good use case for this though :) |
Contributor
Author
|
@stevenpetryk I agree that it's not that important, this PR just makes |
stevenpetryk
approved these changes
Apr 16, 2020
Contributor
stevenpetryk
left a comment
There was a problem hiding this comment.
Nah, I think it's fine to add. Prettier's pretty quick anyway.
Contributor
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use user's prettier config when
--fields-onlyis enabled.This change is