Fix duplicate legal document file creation (#336) #2888
+108
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed LegalDocument.create to .new in Actions::BaseAction to prevent duplicate file writes. Previously, the document was saved twice: once explicitly via create() and again when the parent entity (Contact/Domain) was saved, triggering the before_save callback twice and creating two files on the filesystem with only one linked in the database. Added integration tests to verify single file creation for both contact and domain creation with legal documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed LegalDocument.create to .new in Actions::BaseAction to prevent duplicate file writes. Previously, the document was saved twice: once explicitly via create() and again when the parent entity (Contact/Domain) was saved, triggering the before_save callback twice and creating two files on the filesystem with only one linked in the database. Added integration tests to verify single file creation for both contact and domain creation with legal documents.
close #336